Re: [PATCH v2 1/2] t3418: add testcase showing problems with rebase -i and strategy options

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2018, 19:23 UTC
Message-ID: <xmqqmuvgdods.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CABPp-BEYbC0C+bczQuNTcC_jxVM59czh7HTpqi9dv09fvCjMrA@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 5 quoted lines

> Seems reasonable.  Since these tests were essentially copies of other
> tests within the same file, just for rebase -i instead of -m, should I
> also add another patch to the series fixing up the rebase -m testcase
> to also replace the subshell with a single-shot environment
> assignment?

I personally would think it would be best to leave that to a later day, and take your v3 that properly &&-chains these two assignments.

It may be a good clean-up, but is an overkill if done as a preparatory clean-up in the context of these two small fixes.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.