From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 27 Jun 2018 19:23:59 GMT
Subject: Re: [PATCH v2 1/2] t3418: add testcase showing problems with rebase -i and strategy options
Message-ID: <xmqqmuvgdods.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CABPp-BEYbC0C+bczQuNTcC_jxVM59czh7HTpqi9dv09fvCjMrA@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

> Seems reasonable.  Since these tests were essentially copies of other
> tests within the same file, just for rebase -i instead of -m, should I
> also add another patch to the series fixing up the rebase -m testcase
> to also replace the subshell with a single-shot environment
> assignment?

I personally would think it would be best to leave that to a later
day, and take your v3 that properly &&-chains these two assignments.

It may be a good clean-up, but is an overkill if done as a
preparatory clean-up in the context of these two small fixes.