Re: [PATCH v3] handle lower case drive letters on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2018, 19:53 UTC
Message-ID: <xmqqmuuww7rq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <BL0PR2101MB1012EDB64112A8805A2C3D82F4590@BL0PR2101MB1012.namprd21.prod.outlook.com>

Ben Peart <Ben.Peart@microsoft.com> writes:

Show 27 quoted lines

>> -----Original Message-----
>> From: Junio C Hamano <jch2355@gmail.com> On Behalf Of Junio C Hamano
>> Sent: Thursday, July 12, 2018 3:13 PM
>> To: Ben Peart <Ben.Peart@microsoft.com>
>> Cc: git@vger.kernel.org; sbeller@google.com; johannes.schindelin@gmx.de
>> Subject: Re: [PATCH v3] handle lower case drive letters on Windows
>> 
>> Ben Peart <Ben.Peart@microsoft.com> writes:
>> 
>> > On Windows, if a tool calls SetCurrentDirectory with a lower case drive
>> > letter, the subsequent call to GetCurrentDirectory will return the same
>> > lower case drive letter. Powershell, for example, does not normalize the
>> > path. If that happens, test-drop-caches will error out as it does not
>> > correctly to handle lower case drive letters.
>> >
>> > Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> > Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
>> > ---
>> 
>> Thanks.  Will replace, even though showing the whole Buffer (I am
>> guessing it is the equivalent of result from getcwd(3) call) and
>> complaining about drive "letter" feels a bit strange ;-)
>> 
>
> Thanks.  I thought it was strange as well until I realized you only see the
> error message if there _isn't_ a valid drive letter so seeing the entire
> path makes sense as it will likely be something like "\\server\volume\directory"

Yup, that is why I thought Dscho meant to say something like

	"'%s': path without valid drive prefix"

in my response ;-)