git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1] handle lower case drive letters on Windows

From
Ben Peart <ben.peart@microsoft.com>
Date
Jul 11, 2018, 17:54 UTC
Message-ID
<20180711175420.16940-1-benpeart@microsoft.com>
Teach test-drop-caches to handle lower case drive letters on Windows.
Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
---
Notes:
    Base Ref: master
    Web-Diff: https://github.com/benpeart/git/commit/55b815ee73
    Checkout: git fetch https://github.com/benpeart/git drop-caches-v1 && git checkout 55b815ee73
 t/helper/test-drop-caches.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c
index d6bcfddf13..37047189c3 100644
--- a/t/helper/test-drop-caches.c
+++ b/t/helper/test-drop-caches.c
@@ -16,7 +16,7 @@ static int cmd_sync(void)
 	if ((0 == dwRet) || (dwRet > MAX_PATH))
 		return error("Error getting current directory");
 
-	if ((Buffer[0] < 'A') || (Buffer[0] > 'Z'))
+	if ((toupper(Buffer[0]) < 'A') || (toupper(Buffer[0]) > 'Z'))
 		return error("Invalid drive letter '%c'", Buffer[0]);
 
 	szVolumeAccessPath[4] = Buffer[0];

base-commit: e3331758f12da22f4103eec7efe1b5304a9be5e9
-- 
2.17.0.gvfs.1.123.g449c066
Next: Stefan Beller
Message 1 of 15 in “handle lower case drive letters on Windows”
  1. handle lower case drive letters on WindowsBen Peart, Jul 11, 2018
  2. Stefan BellerJul 11, 2018
  3. Ben PeartJul 11, 2018
  4. Junio C HamanoJul 11, 2018
  5. Ben PeartJul 11, 2018
  6. handle lower case drive letters on WindowsBen Peart, Jul 11, 2018
  7. Johannes SchindelinJul 12, 2018
  8. Junio C HamanoJul 12, 2018
  9. handle lower case drive letters on WindowsBen Peart, Jul 12, 2018
  10. Junio C HamanoJul 12, 2018
  11. Ben PeartJul 12, 2018
  12. Junio C HamanoJul 12, 2018
  13. Ben PeartJul 12, 2018
  14. Junio C HamanoJul 12, 2018
  15. Johannes SchindelinJul 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.