RE: [PATCH v1] handle lower case drive letters on Windows

From: Ben Peart <ben.peart@microsoft.com>
Date: Jul 11, 2018, 19:07 UTC
Message-ID: <BL0PR2101MB1012D2CC0BEA20AB35CBE967F45A0@BL0PR2101MB1012.namprd21.prod.outlook.com>
In-Reply-To: <CAGZ79ka=HfzKprETBJ=+sdQsUZPXgHsgoqNWkbHprUGgLMggUA@mail.gmail.com>

Show 17 quoted lines

> -----Original Message-----
> From: Stefan Beller <sbeller@google.com>
> Sent: Wednesday, July 11, 2018 1:59 PM
> To: Ben Peart <Ben.Peart@microsoft.com>
> Cc: git <git@vger.kernel.org>; Junio C Hamano <gitster@pobox.com>
> Subject: Re: [PATCH v1] handle lower case drive letters on Windows
> 
> On Wed, Jul 11, 2018 at 10:54 AM Ben Peart <Ben.Peart@microsoft.com>
> wrote:
> >
> > Teach test-drop-caches to handle lower case drive letters on Windows.
> 
> As someone not quite familiar with Windows (and using Git there),
> is this addressing a user visible issue, or a developer visible issue?
> (It looks to me as the latter as it touches test code). In which way
> does it improve the life of a developer?
>

It is a developer visible issue. On Windows, file names (including drive letters) are case insensitive. This patch improves the life of a Windows developer by making drive letters case insensitive for the test-drop-caches test application as well. Without this patch "test-drop-caches e" will fail with an error "Invalid drive letter 'e'" instead of succeeding as expected.

> Thanks,
> Stefan