Re: [PATCH v3] handle lower case drive letters on Windows

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 14, 2018, 22:15 UTC
Message-ID: <nycvar.QRO.7.76.6.1807150015350.75@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqva9kurba.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 12 Jul 2018, Junio C Hamano wrote:

Show 19 quoted lines

> Ben Peart <Ben.Peart@microsoft.com> writes:
> 
> >> > Thanks.  I thought it was strange as well until I realized you only
> >> > see the error message if there _isn't_ a valid drive letter so seeing
> >> > the entire path makes sense as it will likely be something like
> >> "\\server\volume\directory"
> >> 
> >> Yup, that is why I thought Dscho meant to say something like
> >> 
> >> 	"'%s': path without valid drive prefix"
> >> 
> >> in my response ;-)
> >
> > I'm fine with that - want me to leave it alone, spin a V4 or have you tweak it?
> 
> That's "helped-by Dscho" patch, so I'd leave it to him by queuing v3
> overnight and wait to deal with the final decision by the weekend
> ;-) That way, I do not have to make a decision on anything Windows
> related.

The tweaked error message is fine by me.

Ciao, Dscho