Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 30, 2019, 18:59 UTC
- Message-ID
- <xmqqmuni3ra8.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20C7B5F4-58DA-43E4-9332-B206C0D070F0@apple.com>
Jeremy Sequoia <jeremyhu@apple.com> writes:
Show 24 quoted lines
>> On Jan 29, 2019, at 15:59, SZEDER Gábor <szeder.dev@gmail.com> wrote: >> >>> On Tue, Jan 29, 2019 at 03:46:07PM -0800, Jeremy Huddleston Sequoia wrote: >>> >>> >>>> On Jan 29, 2019, at 2:47 PM, Junio C Hamano <gitster@pobox.com> wrote: >>>> >>>> This obviously won't be acceptable as-is to my tree. Shouldn't this >>>> be something to be dealt with in config.mak.uname or something that >>>> is meant to define platform-specific customization? >>> >>> The issue here is that we're not locating relocatable perl modules >>> during testing. This is a general problem with testing >>> RUNTIME_PREFIX configurations, and a more general solution to this >>> sledgehammer would be appropriate. I don't think config.mak.uname >>> really makes sense since it's a general RUNTIME_PREFIX issue and not >>> specifically a darwin issue. >> >> But this patch is very darwin-specific ... >> ... > > Yes. This is one of the patches that I said in the 00 message > would certainly not be upstreamable but for which we should find a > general solution to the problem if one is available.
Yes, I do appreciate seeing these non-upstreamable ones, as they serve to illustrate issues that may want to be helped with a bit more customizability in our tree. I suspect some of them may already have enough solution on our side without any need for further patching (e.g. the "version" one Dscho mentioned for the 06/13), though.
BTW, I'll be mostly offline today, so I'll return to the discussion tomorrow.