Re: [PATCH (Apple Git) 01/13] .gitignore: Remove *.s as it matches *.S on case insensitive filesystem
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 30, 2019, 12:42 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1901301340270.41@tvgsbejvaqbjf.bet>
- In-Reply-To
- <534F20EC-2B29-46C3-BAD9-3CBE7312257F@apple.com>
Hi Jeremy,
On Wed, 30 Jan 2019, Jeremy Huddleston Sequoia wrote:
Show 9 quoted lines
> > On Jan 30, 2019, at 03:33, Eric Sunshine <sunshine@sunshineco.com> wrote: > > > > On Tue, Jan 29, 2019 at 3:11 PM Jeremy Huddleston Sequoia > > <jeremyhu@apple.com> wrote: > >> This was causing problems with ppc/sha1ppc.S > > > > What problems, exactly? > > The file is ignored, but it shouldn't be.
As somebody who sometimes (pretty rarely, but definitely more than once a year) generates the assembler files to have a deeper look, I really understand why *.s is ignored, and I think it should stay ignored.
What you probably want instead is
# Accommodate for case-insensitive filesystems where *.s would catch !ppc/sha1ppc.S
after the `*.[aos]` line.
Ciao, Johannes
Show 10 quoted lines
> > > > >> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> > >> --- > >> diff --git a/.gitignore b/.gitignore > >> @@ -195,7 +195,7 @@ > >> -*.[aos] > >> +*.[ao] > >