Re: [PATCH (Apple Git) 06/13] Set Apple Git version during build

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 30, 2019, 13:43 UTC
Message-ID: <nycvar.QRO.7.76.6.1901301439440.41@tvgsbejvaqbjf.bet>
In-Reply-To: <20190129193818.8645-7-jeremyhu@apple.com>

Hi Jeremy,

On Tue, 29 Jan 2019, Jeremy Huddleston Sequoia wrote:

Show 16 quoted lines

> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
> ---
>  GIT-VERSION-GEN | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index d1a2814ec7..6fb90854b9 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -3,6 +3,10 @@
>  GVF=GIT-VERSION-FILE
>  DEF_VER=v2.20.1
>  
> +if [ -n "$RC_ProjectSourceVersion" ] ; then
> +	DEF_VER="$DEF_VER (Apple Git-$RC_ProjectSourceVersion)"
> +fi

This seems awfully specific to a very specific setup. It won't work when building from a Git checkout, either, as `DEF_VER` is not even used then.

And the existing facility is the `version` file. Since you want to build this in some sort of automated fashion anyway, you should probably execute

	sed -n "s/^DEF_VER=\\(.*\\)/\\1 (Apple Git-$RC_ProjectSourceVersion)/p" \
		<GIT-VERSION-GEN >version

in your automation script. As a bonus, this will work with any unpatched Git source code, too!

Ciao, Johannes

Show 8 quoted lines

> +
>  LF='
>  '
>  
> -- 
> 2.20.0 (Apple Git-115)
> 
>