Re: [PATCH (Apple Git) 01/13] .gitignore: Remove *.s as it matches *.S on case insensitive filesystem
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 31, 2019, 19:48 UTC
- Message-ID
- <CAPig+cST93AUt+7LHsigeA2=AHvNwveCPEszP6-kvjpkRTNmQQ@mail.gmail.com>
- In-Reply-To
- <F67B3B30-64D8-4B0D-A4FD-7263415B0064@apple.com>
On Thu, Jan 31, 2019 at 1:17 PM Jeremy Sequoia <jeremyhu@apple.com> wrote:
Show 12 quoted lines
> > On Jan 31, 2019, at 09:57, Junio C Hamano <gitster@pobox.com> wrote: > > I still do not see what problem you need a "solution" for in the > > first place---I saw a few comments asking it in the thread, but saw > > no answer. ppc/sha1ppc.S is already tracked, so any modification > > you make in the working tree can be added to the index with "git > > add" and "git status" would report when you have modification to > > that file in the working tree, without any such extra entry in > > .gitignore, no? > > This would have implications for anyone doing something similar or > to anyone intending to add new assembly files to the tree (since > they wouldn’t show up in status or get added with add -A),
This nugget finally gives readers an idea of the sort of issue this patch wants to "fix", which happens to be related to HFS+ being case-insensitive. As noted upstream, though, files which are already tracked, such as ppc/sha1ppc.S, are not subject to .gitignore, so Dscho's proposed modification to .gitignore:
...
*.[aos]
!ppc/sha1ppc.S
...doesn't actually help. Moreover, this .gitignore change doesn't at all help the case you describe about new assembly files not being noticed by "git status" or "git add -A" since any new files won't be named "ppc/sha1ppc.S".
As Junio said upstream, .gitignore ignoring "*.s" files is the right thing to do for this project and, as adding new .S files is so rare, it seems unlikely that a patch changing .gitignore to accommodate the above use-case for case-insensitive filesystems would make sense to the project as a whole.