Re: committer-date-is-author-date flag removes email in "Commit"

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 23, 2020, 15:23 UTC
Message-ID: <xmqqmu0dhsoz.fsf@gitster.c.googlers.com>
In-Reply-To: <20201023070747.GA2198273@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 19 quoted lines

> On Fri, Oct 23, 2020 at 11:18:51AM +0530, VenomVendor wrote:
>
>> What did you do before the bug happened? (Steps to reproduce your issue)
>> * Create empty repo using `git init`
>> * Make few commits, at least two
>> * execute `git log --format=fuller`
>> * Notice the log, with "Author", "AuthorDate", "Commit", "CommitDate"
>> * Note, "Commit"
>> * execute `git rebase --committer-date-is-author-date HEAD~1`
>> * execute `git log --format=fuller`
>> * Note, email from "Commit" is empty <>
>
> Thanks for a clear report. I was able to easily reproduce the problem.
> There are actually two related bugs here, and they're both regressions
> in v2.29.0.
>
>   [1/3]: t3436: check --committer-date-is-author-date result more carefully
>   [2/3]: am: fix broken email with --committer-date-is-author-date
>   [3/3]: rebase: fix broken email with --committer-date-is-author-date

Thanks for taking quick care of this. It counts as an embarrasing brown-paper-bag bug; it is a bit surprising that nobody noticed it while the original change was discussed.

I wonder if we even needed to do the original change to begin with (stopping to export means not giving information to the hooks), but that is a separate matter.

Will take a look and queue.  Thanks.

Show 7 quoted lines

>
>  builtin/am.c                   | 4 ++--
>  sequencer.c                    | 2 +-
>  t/t3436-rebase-more-options.sh | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> -Peff