Re: committer-date-is-author-date flag removes email in "Commit"

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 23, 2020, 17:59 UTC
Message-ID: <xmqqh7qkhlgw.fsf@gitster.c.googlers.com>
In-Reply-To: <58e83ad2-14a2-5ace-c1fd-8224625a0f97@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 6 quoted lines

>> I wonder if we even needed to do the original change to begin with
>> (stopping to export means not giving information to the hooks), but
>> that is a separate matter.
>
> I think the main motivation was to stop polluting the environment of
> exec commands

As long as the information that used to be exported can be learned by the hook script when/if it wants to (how? read the original commit object with "git show -s --format=..."? How would it know which one is the original commit?), it is fine.

If not, a script that does not want the exported environment variable can easily ignore it (just "unset" it) but to a script that wanted to learn the information that used to be in the environment variable, it's not "stop polluting" but "lose information", and that is where my earlier "I wonder" comes from.