Re: [PATCH 4/3] am, sequencer: stop parsing our own committer ident
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 26, 2020, 17:12 UTC
- Message-ID
- <xmqqft60gbci.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20201023072630.GA2918369@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> By the way, I wondered why we needed to do this parsing at all. The > patch below does this in a much simpler way. It's a little bit ugly, I > think, because we have to call getenv() ourselves. But that's the way > fmt_ident() has always worked. We could probably improve that now that > it takes a whose_ident flag (before that, it had no idea if we wanted > author or committer ident). > > This is on top of the fixes (but we'd perhaps just want to do those on > 'maint' as the minimal fix).
This could be the nicest step in the whole series, but let's leave it out of the branch meant for 'maint'.
Thanks.