Re: [PATCH 4/3] am, sequencer: stop parsing our own committer ident

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 23, 2020, 17:29 UTC
Message-ID: <X5MS5l2bbRczcdgF@nand.local>
In-Reply-To: <20201023074510.GB2918369@coredump.intra.peff.net>

On Fri, Oct 23, 2020 at 03:45:10AM -0400, Jeff King wrote:

Show 15 quoted lines

> On Fri, Oct 23, 2020 at 03:26:30AM -0400, Jeff King wrote:
>
> > By the way, I wondered why we needed to do this parsing at all. The
> > patch below does this in a much simpler way. It's a little bit ugly, I
> > think, because we have to call getenv() ourselves. But that's the way
> > fmt_ident() has always worked. We could probably improve that now that
> > it takes a whose_ident flag (before that, it had no idea if we wanted
> > author or committer ident).
>
> I took a brief look at refactoring fmt_ident() to auto-fill from the
> environment variables (patch below). It's mostly sensible for
> name/email, because callers pass either the environment variables or
> some custom-provided value. But for the date, we sometimes pass NULL to
> mean "use the current time, even if $GIT_*_DATE is set". I'm not 100%
> sure that isn't a bug, though.

That seems like an area where further investigation would be helpful. In the meantime (especially if this is something that Junio wants to queue and call v2.29.2), I'd be happy with the four patches you posted (but waiting on this one below).

Thanks for investigating.

Thanks, Taylor