Re: [PATCH 3/3] notes: don't indent empty lines

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 12, 2021, 08:22 UTC
Message-ID: <xmqqmtoikxt1.fsf@gitster.g>
In-Reply-To: <CAPig+cTRo_bLrCyhWC5on-HHco=H=3Mc6Xfi4gRP0xVE+Xk=BA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> I'm not a fan of the trailing whitespace either, however, Junio does
> have the concern that there may be some tooling somewhere which relies
> upon the "indented blank lines" (even if such tooling would not be
> robust).

Note that such a "concern" is always relative. If the upside were so great, perhaps risking possible breakage may be warranted. FWIW, I am not a big fan of trailing whitespaces that human writers leave in what they write, either.

Because the patch text will be full of lines with trailing whitespaces anyway due to a blank lines in the patch context, however, it does not sound so great an upside to tweak how the paragraphs taken from the notes are inserted.

Thanks.