Re: [PATCH 3/3] notes: don't indent empty lines
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 10, 2021, 05:21 UTC
- Message-ID
- <CAPig+cR5Gm0Jq24EbsuaU2NV4uaT61CcYzE_yyR81OrOw1h3vQ@mail.gmail.com>
- In-Reply-To
- <CAPig+cTFbnrPPSZbzihJ9gdGV2c4poXWyNjhK3mnr5_uRwpxbg@mail.gmail.com>
On Fri, Sep 10, 2021 at 1:18 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 7 quoted lines
> Have we made a decision about whether this patch series -- which > avoids indenting blank notes lines -- is desirable? Or are we worried > about backward-compatibility? If we think there is value in this > series, then I can re-roll with Ævar suggestions. If not, perhaps I > can re-submit just patch [1/3] which makes a few tests less brittle. > Or, since those brittle tests aren't necessarily hurting anything, we > can just let this series die.
I meant [2/3], not [1/3], as a possibility for a standalone re-submission. That's the patch in which a few tests in t3303 and t9301 which care only whether notes are present (or not) are made less brittle by removing dependence upon the default output format of git-log.