Re: [PATCH 3/3] notes: don't indent empty lines
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 10, 2021, 20:31 UTC
- Message-ID
- <CAPig+cQdAuLkZ0pDK6XOfm_WXCJAOm8Tr19oK14n-Tf7DcfW=w@mail.gmail.com>
- In-Reply-To
- <xmqqwnnos2jz.fsf@gitster.g>
On Fri, Sep 10, 2021 at 2:33 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > > Have we made a decision about whether this patch series -- which > > avoids indenting blank notes lines -- is desirable? Or are we worried > > about backward-compatibility? > > I do not know about "have we made" part of the question, but an > input from me to come to an answer to the question is that, while I > can see why it may be desirable in some cases, I do not view it as > compelling enough to risk any unforeseen breakage to other peoples' > workflow. My opinion is based on an assumption that it is desirable > because it would squelch "here is a trailing whitespace" noise in an > editor and/or a pager that is appropriately configured and allow the > user to spot whitespace breakages in the payload more easily and for > no other reason. If there are other reasons that make this change > desirable, they might influence my opinion.
Thank you for the response. I didn't have any other reason beyond squelching "here is trailing whitespace" noise when submitting the series. Thus, I can't provide any other reasons to promote the change as desirable.