Re: [PATCH 3/3] notes: don't indent empty lines

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 10, 2021, 05:18 UTC
Message-ID: <CAPig+cTFbnrPPSZbzihJ9gdGV2c4poXWyNjhK3mnr5_uRwpxbg@mail.gmail.com>
In-Reply-To: <CAPig+cQdXp0c+JYthvy+bbr6vLR7nq4pQY3w+CADUtzr+Ang4A@mail.gmail.com>

On Mon, Aug 30, 2021 at 2:04 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> In the general case, such an extraction mechanism would be far too
> fragile since there are no guarantees that the commentary in the
> "Notes:" section hasn't been hand-edited after patch-generation.
> However, it's certainly possible that such a simple-minded extraction
> technique might be applicable in some well-controlled development
> pipeline somewhere.
>
> If we are worried about that, then we can drop this patch series.

Have we made a decision about whether this patch series -- which avoids indenting blank notes lines -- is desirable? Or are we worried about backward-compatibility? If we think there is value in this series, then I can re-roll with Ævar suggestions. If not, perhaps I can re-submit just patch [1/3] which makes a few tests less brittle. Or, since those brittle tests aren't necessarily hurting anything, we can just let this series die.

Thoughts?