git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] http: add support for different sslcert and sslkey types.

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2023, 00:20 UTC
Message-ID
<xmqqmt3v5btk.fsf@gitster.g>
In-Reply-To
<20230329232347.GB2314218@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> On Wed, Mar 29, 2023 at 11:53:11AM -0700, Junio C Hamano wrote:
>
> ...
>> > But I don't have any idea how to do that with hardware usb eToken in my case.
>> 
>> OK, so where does this put us, with respect to the change?  ...
> I would be OK taking the patches without any further tests. It is not
> really making anything worse in the sense that we already do not test
> any of the client-cert stuff.

Alright. I think the patch has already been queued for some time, and it is OK to merge it down to 'next'.

Show 6 quoted lines
> If we can cheaply add some tests that at least exercise the code and
> hand off to curl, that is better than nothing, I guess.
>
> I think the ideal would be a new t5565 that sets LIB_HTTPD_SSL
> unconditionally and actually tests various client-cert formats and
> requests using a made-on-the-fly cert.
Thanks.
Previous: Jeff King
Message 16 of 16 in “That change for support different sslcert and sslkey types.”
  1. That change for support different sslcert and sslkey types.Stanislav Malishevskiy via GitGitGadget, Mar 19, 2023
  2. http: add support for different sslcert and sslkey types.Stanislav Malishevskiy via GitGitGadget, Mar 20, 2023
  3. Jeff KingMar 20, 2023
  4. Stanislav MMar 20, 2023
  5. Jeff KingMar 21, 2023
  6. Junio C HamanoMar 20, 2023
  7. Stanislav MMar 20, 2023
  8. Jeff KingMar 21, 2023
  9. Junio C HamanoMar 21, 2023
  10. Stanislav MMar 23, 2023
  11. Jeff KingMar 23, 2023
  12. Stanislav MMar 23, 2023
  13. Junio C HamanoMar 29, 2023
  14. Stanislav MMar 29, 2023
  15. Jeff KingMar 29, 2023
  16. Junio C HamanoMar 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.