Re: [PATCH v2] http: add support for different sslcert and sslkey types.

From: Jeff King <peff@peff.net>
Date: Mar 21, 2023, 17:22 UTC
Message-ID: <20230321172223.GA3119834@coredump.intra.peff.net>
In-Reply-To: <xmqqlejrmj4y.fsf@gitster.g>

On Mon, Mar 20, 2023 at 10:23:41AM -0700, Junio C Hamano wrote:

> Is this something that can be protected from future breakage with a
> few new tests somewhere in t/t5559 (which may also involve touching
> t/lib-httpd.sh as well)?

I don't think we'd want to put it there. While it is the only test that requires SSL currently, it's also specific to HTTP/2, so it may not get run everywhere.

The original design of the SSL support in the test suite was that you'd do a run of the whole suite with LIB_HTTPD_SSL set, and then it would run all of the usual tests with ssl. But experience has shown that nobody does that. So I think there are two paths forward here:

  1. Add a mode to CI that runs with LIB_HTTPD_SSL set. We'd need to fix
     the bit-rotted tests that fail (usually due to things like
     expecting "http" in the output instead of "https", etc). I linked
     to earlier discussion there elsewhere in the thread.

  2. Add a specific "test with https" script that covers some basic
     tests (possibly even just including t5551, in the same way t5559
     does). If the platform apache doesn't support ssl, then it should
     fail gracefully. And then we could add more SSL specific tests
     to that script.

-Peff