Re: [PATCH v2] http: add support for different sslcert and sslkey types.

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2023, 18:53 UTC
Message-ID: <xmqqfs9n9yp4.fsf@gitster.g>
In-Reply-To: <CAEpdKfm0S4tkLz8DMnkJmhMmJk8Cj1tUm7NbMe7kpATq0bkxCw@mail.gmail.com>

Stanislav M <stanislav.malishevskiy@gmail.com> writes:

[administrivia: do not top-post]

Show 8 quoted lines

>> Yes, but I'm not sure if there is a way for Git to trigger curl to look
>> at the certificate that does not involve feeding it an https URL (and we
>> want a valid one, because we want to see that it correctly speaks to the
>> server).
> ...
> In my opinion they need the same set of tests which is used as usual
> for https. But use the right certificate and key.
> But I don't have any idea how to do that with hardware usb eToken in my case.

OK, so where does this put us, with respect to the change? We have some behaviour change that we do not know how to test? How would we know when we break it in the future? It is not like the new feature is not useful enough that nobody would care if it gets broken by accident or anything like that, so...?

At least perhaps we can throw bogus strings in the environment and make sure cURL library gives complaints, or something?

Thanks.