Re: [PATCH v2] http: add support for different sslcert and sslkey types.

From: Stanislav M <stanislav.malishevskiy@gmail.com>
Date: Mar 20, 2023, 18:24 UTC
Message-ID: <CAEpdKfnWHtbZDFGhYhz81DRMiG8tbuw1CVWrd7ppSj++pODdYQ@mail.gmail.com>
In-Reply-To: <xmqqlejrmj4y.fsf@gitster.g>

> Is this something that can be protected from future breakage with a
> few new tests somewhere in t/t5559 (which may also involve touching
> t/lib-httpd.sh as well)?

I am not sure about that. That required only for local access to the cert and key from curl

пн, 20 мар. 2023 г. в 20:23, Junio C Hamano <gitster@pobox.com>:

Show 22 quoted lines

>
> "Stanislav Malishevskiy via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Stanislav Malishevskiy <s.malishevskiy@auriga.com>
> >
> > Basically git work with default curl ssl type - PEM. But for support
> > eTokens like SafeNet tokens via pksc11 need setup 'ENG' as sslcert type
> > and as sslkey type. So there added additional options for http to make
> > that possible.
> >
> > Signed-off-by: Stanislav Malishevskiy <stanislav.malishevskiy@gmail.com>
> > ---
>
> >  http.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
>
> Thanks.
>
> Is this something that can be protected from future breakage with a
> few new tests somewhere in t/t5559 (which may also involve touching
> t/lib-httpd.sh as well)?