Re: What's cooking in git.git (Jul 2026, #12)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 5, 2026, 17:03 UTC
- Message-ID
- <xmqqmrv0qz3d.fsf@gitster.g>
- In-Reply-To
- <47bd0302-fc52-4df0-98a0-6fad7eb0fb05@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 17 quoted lines
> Hi Junio > > On 29/07/2026 18:48, Junio C Hamano wrote: >> >> Perhaps the sensible thing for me to do is to stop taking any new >> topics into 'seen', even if I've spotted them, until I see somebody >> give them a real review. >> >> Otherwise, it becomes too tempting for me to jump in, give them a >> superficial read after seeing them linger in the "What's Cooking" >> draft in the "Needs review" state for too long, and, believing I've >> seen enough, mark them for 'next'. If I don't queue a patch that >> nobody seems to have read carefully, I won't succumb to such >> temptation. > > Maybe, though I do find having the patches in seen makes it easier to do > an in-depth review as it means I don't have to apply them myself.
Yes, that is a very good point. And if the authors are paying attention, it would hopefully also help them how well their changes play with others' changes.
OK, then I will keep picking them up, but under these conditions:
(1) They will not leave 'seen' without anyone commenting on them;
(2) They will automatically be discarded after four weeks without
positive feedback; and(3) I will not feel obligated to review them even if no one steps up.
Thanks.