Re: What's cooking in git.git (Jul 2026, #12)

From: Matt Hunter <m@lfurio.us>
Date: Jul 31, 2026, 06:20 UTC
Message-ID: <DKCJF4116DLD.3B078238N2B12@lfurio.us>
In-Reply-To: <xmqq1pclc210.fsf@gitster.g>

On Wed Jul 29, 2026 at 10:18 AM EDT, Junio C Hamano wrote:

Show 14 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>>>   The experimental 'git history' command has been taught a new 'squash'
>>>   subcommand to fold a range of commits into a single commit, with any
>>>   descendants replayed on top.
>>> 
>>>   Will merge to 'master'.
>>>   cf. <DK1KIF2OI8IF.11188A3YEQV1C@lfurio.us>
>>>   cf. <DK1KIH6CXW0X.1U2V3GU8L6HB7@lfurio.us>
>>>   source: <pull.2337.v10.git.git.1784536024.gitgitgadget@gmail.com>
>>
>> Oh, I'd missed this going into master. Has the implementation received 
>> any serious review? I've seen messages from a couple of people trying it 
>> out but I can't see anybody reading the code.

I believe I was one of the last people to comment on it. I _had_ done a read through of the code, spotted some things, but appear to have missed these more nuanced interactions. My last "lgtm" message in the thread really meant to say "these latest fixes sufficiently address my comments". And as someone who doesn't have much history on the mailing list, I assumed Junio would weigh my approval accordingly :)

I didn't notice this had advanced to next either, and may have spoken up sooner if I did.

So given all that, assuming I had come along and looked at these patches, but found no issues in the first place, I probably would have stayed silent. Should I be more careful with such a blanket "this is good" message in the future?

Sorry for any hassle - though I don't expect you "blame" reviewers for this sort of thing. It's a lot harder to demonstrate correctness than point out some potential problem.