Re: What's cooking in git.git (Jul 2026, #12)
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Jul 29, 2026, 15:20 UTC
- Message-ID
- <414ebe62-c7f6-4d44-bde2-b689e35accfc@gmail.com>
- In-Reply-To
- <xmqq1pclc210.fsf@gitster.g>
On 29/07/2026 15:18, Junio C Hamano wrote:
Show 25 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: > >>> The experimental 'git history' command has been taught a new 'squash' >>> subcommand to fold a range of commits into a single commit, with any >>> descendants replayed on top. >>> >>> Will merge to 'master'. >>> cf. <DK1KIF2OI8IF.11188A3YEQV1C@lfurio.us> >>> cf. <DK1KIH6CXW0X.1U2V3GU8L6HB7@lfurio.us> >>> source: <pull.2337.v10.git.git.1784536024.gitgitgadget@gmail.com> >> >> Oh, I'd missed this going into master. Has the implementation received >> any serious review? I've seen messages from a couple of people trying it >> out but I can't see anybody reading the code. > > Thanks for stopping me. I am happy to immediately revert the merge > of this topic into 'next'. > > Perhaps I should re-evaluate the "What's Cooking" report and eject > other topics from 'next' as well. There are indeed topics I did not > personally read, relying instead on impressions from busy exchanges > (including earlier iterations read by others X-<). > > Are there other topics in 'next' that do not deserve to be there > yet?
There aren't any others that I'm aware of, but I've not looked at most of them so that probably does not mean much.
Show 5 quoted lines
> I cannot, of course, afford to be the sole serious reviewer and > merge only those I have carefully read through, given that there are > only 24 hours in a day and I have other obligations. So either our > quality criteria must suffer, like this episode showed us, or more > topics must be ignored.
Yes, we could really do with more reviewers
Show 10 quoted lines
>> Having a quick look >> through it assumes the presence of an UNINTERESTING commit means we have >> a BOTTOM commit. It then assumes that UNINTERESTING commit means we >> cannot reach any root commits. Both of those assumptions are false I >> think. > > Very true. > >> ... I'll try and go through the patches and produce some fixups, >> though that may not be until next week.
Harald - I've got some half finished fixups that I didn't get round it finishing when I had a look at this last week that I'll clean up and send so I'd hold off re-rolling for now.
Thanks
Phillip