Re: What's cooking in git.git (Jul 2026, #12)

From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Jul 30, 2026, 06:11 UTC
Message-ID: <CAHwyqnXYi76rMOWYEgJhoh2rXaTgLbze7mKd+WGoC9BbDFHXHA@mail.gmail.com>
In-Reply-To: <f5f7af53-df3e-4902-b350-8fcf8ccb02ad@gmail.com>

Show 9 quoted lines

> Without "--reedit-message", it will happily discard "amend!" and
> "squash!" commit messages even though the user creating them is a strong
> signal that they intended to use them to reword the commit.
> "--reedit-message" is a rather verbose option name which does not make
> sense to me as we're creating a new commit with a new message so we're
> not re-editing anything. I've commented elsewhere that I strongly
> dislike reusing the rebase squash message template for this command
> where we can squash fixups into multiple different commits at the same
> time.

Should we always do "--reedit-message" then, i.e. remove the option and have it as the default? Do we need a "--no-edit" switch then instead? Maybe not, user will then always have the editor opened and they can save and quit if they don't care.

I'm not sure about changing the template.

Harald