Re: [PATCH v7 0/7] recursively grep across submodules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 16, 2016, 21:42 UTC
- Message-ID
- <xmqqlgvfr1o7.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1481915002-162130-1-git-send-email-bmwill@google.com>
Brandon Williams <bmwill@google.com> writes:
Show 8 quoted lines
> Changes in v7: > * Rebased on 'origin/bw/realpath-wo-chdir' in order to fix the race condition > that occurs when verifying a submodule's gitdir. > * Reverted is_submodule_populated() to use resolve_gitdir() now that there is > no race condition. > * Added !MINGW to a test in t7814 so that it won't run on windows. This is due > to testing if colons in filenames are still handled correctly, yet windows > doesn't allow colons in filenames.
Nice.
Will queue again to see if those on other platforms have troubles with it. I read it through again and think the series is ready for 'next'.
Thanks.