Re: [PATCH v3 0/6] recursively grep across submodules
- From
Stefan Beller <sbeller@google.com>
- Date
- Nov 15, 2016, 17:42 UTC
- Message-ID
- <CAGZ79kbiXYKBjJL75bkgAOC+STTKk0F=9TVafpcT-50+ZAcStw@mail.gmail.com>
- In-Reply-To
- <1478908273-190166-1-git-send-email-bmwill@google.com>
coverity seems to dislike this part:
*** CID 1394367: Null pointer dereferences (NULL_RETURNS) /builtin/grep.c: 625 in grep_submodule() 619 is_submodule_populated(path))) { 620 /* 621 * If searching history, check for the presense of the 622 * submodule's gitdir before skipping the submodule. 623 */ 624 if (sha1) {
>>> CID 1394367: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "submodule_from_path(null_sha1, path)".
625 path = git_path("modules/%s", 626 submodule_from_path(null_sha1, path)->name); 627 628 if (!(is_directory(path) && is_git_directory(path))) 629 return 0; 630 } else {