Re: [PATCH v3 5/6] grep: enable recurse-submodules to work on <tree> objects

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2016, 18:56 UTC
Message-ID: <xmqqfumtyjoy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <c83066bc-5b2b-998c-7e22-c4fccbaba5de@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 16 quoted lines

>>> to:
>>> HEAD:file
>>> HEAD:sub/file
>>>
>>> Signed-off-by: Brandon Williams <bmwill@google.com>
>>> ---
>>
>> Unrelated tangent, but this makes readers wonder what the updated
>> trailer code would do to the last paragraph ;-).  Does it behave
>> sensibly (with some sane definition of sensibleness)?
>>
>> I am guessing that it would, because neither To: or HEAD: is what we
>> normally recognize as a known trailer block element.
>
> Yes, it behaves sensibly :-) because "Signed-off-by:" is preceded by a
> blank line, so the trailer block consists only of that line.

Oh, that was not what I was wondering. Imagine Brandon writing his message that ends in these three questionable lines and then running "commit -s --amend" to add his sign-off---that was the case I was wondering.