Re: [PATCH v6 1/6] submodules: add helper functions to determine presence of submodules

From: Jeff King <peff@peff.net>
Date: Dec 1, 2016, 20:59 UTC
Message-ID: <20161201205944.2py2ijranq4g2wap@sigill.intra.peff.net>
In-Reply-To: <20161201205444.GG54082@google.com>

On Thu, Dec 01, 2016 at 12:54:44PM -0800, Brandon Williams wrote:

Show 8 quoted lines

> > I think this more robust check is probably a good idea, that way we
> > don't step into a submodule with a .git directory that isn't really a
> > .git dir.
> 
> Looks like this is a no-go as well...the call to is_git_directory() ends
> up calling real_path...which ends up performing the chdir call, which
> puts us right back to where we started!  (as a side note I was using
> is_git_directory else where...which I now know I can't use)

Bleh. Looks like it happens as part of the recently-added get_common_dir(). I'm not sure if that is ever relevant for submodules, but I guess in theory you could have a submodule clone that is part of a worktree?

-Peff