Re: [PATCH v2 2/2] receive-pack: verify push options in cert

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2017, 03:15 UTC
Message-ID: <xmqqlgq64t5k.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <cc21a5566dcf10e4683465ac253c76370b7b6a7f.1494279020.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> Teach receive-pack, in the case that push options are provided for a
> signed push, to verify that the push options both within the cert and
> outside the cert are consistent.

Thanks. The idea was that the certificate should record how the push was made fully, hence we need two copies. The one outside the certificate is meant to be actually used, but obviously we need to make sure that matches what is recorded in the certificate.

In retrospect, we could have required the receiver who groks signed pushes to only look inside the certificate for options etc. so that the sender can omit the "extra" copies outside the certificate, but that is not how the current protocol is structured, hence ...

> This sets in stone the requirement that send-pack redundantly send its
> push options in 2 places,...

... this requirement.

Thanks.