Re: [PATCH 1/3] docs: correct receive.advertisePushOptions default
- From
Stefan Beller <sbeller@google.com>
- Date
- May 5, 2017, 23:53 UTC
- Message-ID
- <CAGZ79kaq5x4RdXiopcP+-NvAiwkLE6A1yBjbHVaghDVRvOu-6A@mail.gmail.com>
- In-Reply-To
- <20170505235017.GC55152@google.com>
On Fri, May 5, 2017 at 4:50 PM, Brandon Williams <bmwill@google.com> wrote:
Show 12 quoted lines
> On 05/05, Jonathan Tan wrote:
>> In commit c714e45 ("receive-pack: implement advertising and receiving
>> push options", 2016-07-14), receive-pack was taught to (among other
>> things) advertise that it understood push options, depending on
>> configuration. It was documented that it advertised such ability by
>> default; however, it actually does not. (In that commit, notice that
>> advertise_push_options defaults to 0, unlike advertise_atomic_push which
>> defaults to 1.)
>
> This looks like a good fix to the documentation as advertise_push_options
> does indeed default to 0.
>Indeed.
Thanks, Stefan