Re: [PATCH v2 2/2] receive-pack: verify push options in cert
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 9, 2017, 03:34 UTC
- Message-ID
- <xmqqfuge4sak.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <cc21a5566dcf10e4683465ac253c76370b7b6a7f.1494279020.git.jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
> + # Tweak the push output to make the push option outside the cert > + # different, then replay it on a fresh dst, checking that ff is not > + # deleted. > + sed -i "s/\\([^ ]\\)bar/\\1baz/" push &&
This is not portable. Didn't you get an error from the lint checker?
The attached may not be enough if "push" is a binary file, though, in which case perl may be your friend ;-)
t/t5534-push-signed.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5534-push-signed.sh b/t/t5534-push-signed.sh index 0ef6f66b5d..effe769688 100755 --- a/t/t5534-push-signed.sh +++ b/t/t5534-push-signed.sh @@ -152,11 +152,11 @@ test_expect_success GPG 'inconsistent push options in signed push not allowed' ' # Tweak the push output to make the push option outside the cert # different, then replay it on a fresh dst, checking that ff is not # deleted. - sed -i "s/\\([^ ]\\)bar/\\1baz/" push && + sed -e "s/\\([^ ]\\)bar/\\1baz/" push >push.tweak && prepare_dst && git -C dst config receive.certnonceseed sekrit && git -C dst config receive.advertisepushoptions 1 && - git receive-pack dst <push >out && + git receive-pack dst <push.tweak >out && git -C dst rev-parse ff && grep "inconsistent push options" out '