Re: [PATCH v1 0/2] Cleanup tests for test_cmp argument ordering and "|" placement

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2018, 15:55 UTC
Message-ID: <xmqqlg82ah7a.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cover.1536969438.git.matvore@google.com>

Matthew DeVore <matvore@google.com> writes:

Show 6 quoted lines

> As requested in:
>  https://public-inbox.org/git/xmqqmuskas3a.fsf@gitster-ct.c.googlers.com/
> this patchset corrects ordering of test_cmp arguments and | placement.
>
> The request didn't explicitly state whether all the tests should be cleaned up,
> but I did clean up as much as I reasonably could.

I was only suggesting a clean-up of the test scripts you are going to touch anyway in your series, and not the ones outside that original scope. Your going above and beyond what is necessary to make sure your primary changes will be protected against future breakage is surely appreciated but it would of course require more review resources ;-).