Re: [PATCH v1 2/2] t/*: fix ordering of expected/observed arguments

From: Matthew DeVore <matvore@google.com>
Date: Sep 17, 2018, 12:56 UTC
Message-ID: <CAMfpvhKEdtNUMnTa+Su55FLj30hmnr+KrxBtYAVjSuY1pX-Bpw@mail.gmail.com>
In-Reply-To: <7bc3b618ea90f3a2b7dcdbd269c23c049f4ded0e.1536969438.git.matvore@google.com>

On Fri, Sep 14, 2018 at 5:03 PM Matthew DeVore <matvore@google.com> wrote:

Show 7 quoted lines

>
> This fixes various places where the ordering was obviously wrong and it
> was either related to other patches in this patchset or was easy
> find with grep.
>
> Signed-off-by: Matthew DeVore <matvore@google.com>
> ---

The clause about "related to other patches in this patchset is wrong, so I've reworded the commit message body:

    Fix various places where the ordering was obviously wrong, meaning it
    was easy to find with grep.

Show 9 quoted lines

> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -1620,7 +1620,7 @@ test_expect_success 'show stash info with "--show-stash"' '
>
>  test_expect_success 'no stash info with "--show-stash --no-show-stash"' '
>         git status --show-stash --no-show-stash >expected_without_stash &&
> -       test_cmp expected_default expected_without_stash
> +       test_cmp expected_without_stash expected_default
>  '

This line should not have been changed, so I've reverted it.