Re: [PATCH v3 1/5] CodingGuidelines: add shell piping guidelines
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 21, 2018, 02:06 UTC
- Message-ID
- <CAPig+cT2qMvT2LW482cXQpGnTmNw8KWsH3d0bW4t0vgJ3p59SQ@mail.gmail.com>
- In-Reply-To
- <7dd9a1120726dee34aeebdfa4bf45a232c185500.1537493611.git.matvore@google.com>
On Thu, Sep 20, 2018 at 9:43 PM Matthew DeVore <matvore@google.com> wrote:
> Add two guidelines:
Probably s/two/three/ or s/two/several/ since the patch now adds three guidelines.
> - pipe characters should appear at the end of lines, and not cause > indentation
The "not cause indentation" bit is outdated since the added guideline no longer says this.
> - pipes should be avoided when they swallow exit codes that can > potentially fail
And:
- $(git ...) should be avoided ...