Re: [PATCH v3 1/5] CodingGuidelines: add shell piping guidelines

From: Matthew DeVore <matvore@google.com>
Date: Sep 21, 2018, 21:03 UTC
Message-ID: <CAMfpvhJX-KJa7aoGvNLLzQOJQq=BOxQubrUhO1mXpP+6Je6WAg@mail.gmail.com>
In-Reply-To: <CAPig+cT2qMvT2LW482cXQpGnTmNw8KWsH3d0bW4t0vgJ3p59SQ@mail.gmail.com>

On Thu, Sep 20, 2018 at 7:06 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 19 quoted lines

>
> On Thu, Sep 20, 2018 at 9:43 PM Matthew DeVore <matvore@google.com> wrote:
> > Add two guidelines:
>
> Probably s/two/three/ or s/two/several/ since the patch now adds three
> guidelines.
>
> >  - pipe characters should appear at the end of lines, and not cause
> >    indentation
>
> The "not cause indentation" bit is outdated since the added guideline
> no longer says this.
>
> >  - pipes should be avoided when they swallow exit codes that can
> >    potentially fail
>
> And:
>
>     - $(git ...) should be avoided ...

Thank you for pointing this out - I obviously forgot to update the commit message. Here is the revised message:

CodingGuidelines: add shell piping guidelines

Add the following guidelines:

 - pipe characters should appear at the end of lines, not the beginning,
   and the \ line continuation character should be omitted
 - pipes and $(git ...) should be avoided when they swallow exit codes
   of processes that can potentially fail