Re: [PATCH 0/2] stash: handle pathspec magic again
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 18, 2019, 07:02 UTC
- Message-ID
- <xmqqlg1c1x7v.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <xmqq8sxc6bjt.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > >> Fine. But in that case, I would appreciate not being reminded of the >> messiness. Not unless you let me do something about it. Don't put me >> between a rock and a hard place, please.
Perhaps your attitude is coming from a fundamental misunderstanding of the process. Don't be unnecessarily defensive, as nobody is being hostile or attacking you.
It's not like this is a competition to see if your taste as a developer is better or worse than others (including me). It is a cooperative process and everybody involved is "at fault" if we made a mistake. Ending up with a suboptimal history in 'next' is not creditable solely to you. I am as much to blame, so are others who advocated to merge it to 'next' even it were not ready. Or those who did not speak up before it was too late, for that matter.
> Gagging me won't change the fact that the history we ended up is > messy. Without getting reminded of our past mistake(s) ourselves, > what else encourages us to do better the next time?