git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] built-in stash: handle :(glob) pathspecs again

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Mar 11, 2019, 22:19 UTC
Message-ID
<20190311221929.GI31533@hank.intra.tgummerer.com>
In-Reply-To
<nycvar.QRO.7.76.6.1903111726050.41@tvgsbejvaqbjf.bet>
On 03/11, Johannes Schindelin wrote:
Show 9 quoted lines
> Hi Junio,
> 
> On Mon, 11 Mar 2019, Junio C Hamano wrote:
> 
> > Yup.  I think Thomas and Peff were also looking at the vicinity of
> > this code wrt the pass-by-value-ness of ps parameter.  Their fix
> > need to also come on top of this (or combined together).
> 
> I agree. How can I help?

I just sent an updated version of my patch, based on top of this at [*1*]. Would be great if you could review that :)

*1*: https://public-inbox.org/git/20190311221624.GC16414@hank.intra.tgummerer.com/
Previous: Johannes SchindelinNext: Junio C Hamano
Message 7 of 13 in “stash: handle pathspec magic again”
  1. 0/2 stash: handle pathspec magic againJohannes Schindelin via GitGitGadget, Mar 7, 2019
  2. 1/2 legacy stash: fix "rudimentary backport of -q"Johannes Schindelin via GitGitGadget, Mar 7, 2019
  3. Junio C HamanoMar 11, 2019
  4. 2/2 built-in stash: handle :(glob) pathspecs againJohannes Schindelin via GitGitGadget, Mar 7, 2019
  5. Junio C HamanoMar 11, 2019
  6. Johannes SchindelinMar 11, 2019
  7. Thomas GummererMar 11, 2019
  8. Junio C HamanoMar 8, 2019
  9. Johannes SchindelinMar 8, 2019
  10. Junio C HamanoMar 10, 2019
  11. Johannes SchindelinMar 11, 2019
  12. Junio C HamanoMar 18, 2019
  13. Junio C HamanoMar 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.