git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] stash: handle pathspec magic again

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 7, 2019, 15:29 UTC
Message-ID
<pull.159.git.gitgitgadget@gmail.com>

It was reported in https://github.com/git-for-windows/git/issues/2037 that git stash -- ':(glob)**/*.testextension is broken. The problem is not even the stash operation itself, it happens when the git add part of dropping the local changes is spawned: we simply passed the parsed pathspec instead of the unparsed one.

While verifying the fix, I also realized that the escape hatch was seriously broken by my "backport of the -q option": It introduced four bogus eval statements, which really need to be dropped.

Johannes Schindelin (2):
  legacy stash: fix "rudimentary backport of -q"
  built-in stash: handle :(glob) pathspecs again
 builtin/stash.c                    | 5 +++--
 git-legacy-stash.sh                | 8 ++++----
 t/t3905-stash-include-untracked.sh | 6 ++++++
 3 files changed, 13 insertions(+), 6 deletions(-)
base-commit: 7906af0cb84c8e65656347909abd4e22b04d1c1e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-159%2Fdscho%2Fstash-with-globs-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-159/dscho/stash-with-globs-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/159
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 13 in “stash: handle pathspec magic again”
  1. 0/2 stash: handle pathspec magic againJohannes Schindelin via GitGitGadget, Mar 7, 2019
  2. 1/2 legacy stash: fix "rudimentary backport of -q"Johannes Schindelin via GitGitGadget, Mar 7, 2019
  3. Junio C HamanoMar 11, 2019
  4. 2/2 built-in stash: handle :(glob) pathspecs againJohannes Schindelin via GitGitGadget, Mar 7, 2019
  5. Junio C HamanoMar 11, 2019
  6. Johannes SchindelinMar 11, 2019
  7. Thomas GummererMar 11, 2019
  8. Junio C HamanoMar 8, 2019
  9. Johannes SchindelinMar 8, 2019
  10. Junio C HamanoMar 10, 2019
  11. Johannes SchindelinMar 11, 2019
  12. Junio C HamanoMar 18, 2019
  13. Junio C HamanoMar 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.