Re: [PATCH 0/2] stash: handle pathspec magic again

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 8, 2019, 16:12 UTC
Message-ID: <nycvar.QRO.7.76.6.1903081709220.41@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq5zsukuyj.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Fri, 8 Mar 2019, Junio C Hamano wrote:

Show 17 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> > It was reported in https://github.com/git-for-windows/git/issues/2037 that 
> > git stash -- ':(glob)**/*.testextension is broken. The problem is not even
> > the stash operation itself, it happens when the git add part of dropping the
> > local changes is spawned: we simply passed the parsed pathspec instead of
> > the unparsed one.
> >
> > While verifying the fix, I also realized that the escape hatch was seriously
> > broken by my "backport of the -q option": It introduced four bogus eval 
> > statements, which really need to be dropped.
> 
> Thanks.
> 
> We seem to be piling many "oops" on top, even after the topic hits
> 'next'.  But fixes are better late than never ;-).

Yes, we do. At least now I do not have the impression that I have to impose on Paul to integrate whatever diffs I came up with, I can now just submit small patch series that are easily reviewed.

If you care deeply about the commit history, I hereby offer to you to clean up the built-in stash patches when you say you're ready to advance them to `master`; I will then squash the fixes into the proper places to make it a nicer read, with the promise that the tree will be the same in the end as with the oops-upon-oops patch history that we're piling up in `next`. I would do that for you.

> Will queue.

Thanks, Dscho