git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/14] cmd_{read,write}_tree: rename "unused" variable that is used

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2019, 05:14 UTC
Message-ID
<xmqqlfzbc4wo.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190509212724.GA15837@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I kind of hate "cmd_prefix"; I was tempted to just call it "prefix" so
> that all of the cmd_* functions were consistent, but I worried that it
> really would get confused with the local variables (even if those
> variables are renamed, as I do here).

I tend to agree with your temptation to make things consisten, especially because you already do the renaming of existing "prefix" to "tree_prefix".

Perhaps in a few release cycles, these can be renamed again to be consistent with everybody else, and I won't die if this were called cmd_prefix until then ;-)

Previous: Derrick StoleeNext: Jeff King
Message 4 of 20 in “"final" batch of unused parameter cleanups”
  1. 0/14 "final" batch of unused parameter cleanupsJeff King, May 9, 2019
  2. 01/14 cmd_{read,write}_tree: rename "unused" variable that is usedJeff King, May 9, 2019
  3. Derrick StoleeMay 10, 2019
  4. Junio C HamanoMay 13, 2019
  5. 02/14 submodule: drop unused prefix parameter from some functionsJeff King, May 9, 2019
  6. 03/14 builtin: consistently pass cmd_* prefix to parse_optionsJeff King, May 9, 2019
  7. Derrick StoleeMay 10, 2019
  8. 04/14 clone: drop dest parameter from copy_alternates()Jeff King, May 9, 2019
  9. 05/14 read-cache: drop unused parameter from threaded loadJeff King, May 9, 2019
  10. 06/14 wt-status: drop unused status parameterJeff King, May 9, 2019
  11. 07/14 mktree: drop unused length parameterJeff King, May 9, 2019
  12. 08/14 name-rev: drop unused parameters from is_better_name()Jeff King, May 9, 2019
  13. 09/14 pack-objects: drop unused rev_info parametersJeff King, May 9, 2019
  14. 10/14 receive-pack: drop unused "commands" from prepare_shallow_update()Jeff King, May 9, 2019
  15. 11/14 remove_all_fetch_refspecs(): drop unused "remote" parameterJeff King, May 9, 2019
  16. 12/14 rev-list: drop unused void pointer from finish_commit()Jeff King, May 9, 2019
  17. 13/14 show-branch: drop unused parameter from show_independent()Jeff King, May 9, 2019
  18. 14/14 verify-commit: simplify parameters to run_gpg_verify()Jeff King, May 9, 2019
  19. Derrick StoleeMay 10, 2019
  20. Derrick StoleeMay 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.