git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/14] pack-objects: drop unused rev_info parameters

From
Jeff King <peff@peff.net>
Date
May 9, 2019, 21:31 UTC
Message-ID
<20190509213116.GI15837@sigill.intra.peff.net>
In-Reply-To
<20190509212558.GA15438@sigill.intra.peff.net>

When collecting the list of objects to pack in get_object_list(), we pass our rev_info struct around to some functions that don't need it. This is due to 03a9683d22 (Simplify is_kept_pack(), 2009-02-28), where the kept-pack handling was moved out of the revision machinery.

Let's drop these unused parameters.
Signed-off-by: Jeff King <peff@peff.net>
---
 builtin/pack-objects.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index d7743f110b..fea757fea2 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -2899,7 +2899,7 @@ static int ofscmp(const void *a_, const void *b_)
 		return oidcmp(&a->object->oid, &b->object->oid);
 }
 
-static void add_objects_in_unpacked_packs(struct rev_info *revs)
+static void add_objects_in_unpacked_packs(void)
 {
 	struct packed_git *p;
 	struct in_pack in_pack;
@@ -3011,7 +3011,7 @@ static int loosened_object_can_be_discarded(const struct object_id *oid,
 	return 1;
 }
 
-static void loosen_unused_packed_objects(struct rev_info *revs)
+static void loosen_unused_packed_objects(void)
 {
 	struct packed_git *p;
 	uint32_t i;
@@ -3158,11 +3158,11 @@ static void get_object_list(int ac, const char **av)
 	}
 
 	if (keep_unreachable)
-		add_objects_in_unpacked_packs(&revs);
+		add_objects_in_unpacked_packs();
 	if (pack_loose_unreachable)
 		add_unreachable_loose_objects();
 	if (unpack_unreachable)
-		loosen_unused_packed_objects(&revs);
+		loosen_unused_packed_objects();
 
 	oid_array_clear(&recent_objects);
 }
-- 
2.21.0.1382.g4c6032d436
Previous: Jeff KingNext: Jeff King
Message 13 of 20 in “"final" batch of unused parameter cleanups”
  1. 0/14 "final" batch of unused parameter cleanupsJeff King, May 9, 2019
  2. 01/14 cmd_{read,write}_tree: rename "unused" variable that is usedJeff King, May 9, 2019
  3. Derrick StoleeMay 10, 2019
  4. Junio C HamanoMay 13, 2019
  5. 02/14 submodule: drop unused prefix parameter from some functionsJeff King, May 9, 2019
  6. 03/14 builtin: consistently pass cmd_* prefix to parse_optionsJeff King, May 9, 2019
  7. Derrick StoleeMay 10, 2019
  8. 04/14 clone: drop dest parameter from copy_alternates()Jeff King, May 9, 2019
  9. 05/14 read-cache: drop unused parameter from threaded loadJeff King, May 9, 2019
  10. 06/14 wt-status: drop unused status parameterJeff King, May 9, 2019
  11. 07/14 mktree: drop unused length parameterJeff King, May 9, 2019
  12. 08/14 name-rev: drop unused parameters from is_better_name()Jeff King, May 9, 2019
  13. 09/14 pack-objects: drop unused rev_info parametersJeff King, May 9, 2019
  14. 10/14 receive-pack: drop unused "commands" from prepare_shallow_update()Jeff King, May 9, 2019
  15. 11/14 remove_all_fetch_refspecs(): drop unused "remote" parameterJeff King, May 9, 2019
  16. 12/14 rev-list: drop unused void pointer from finish_commit()Jeff King, May 9, 2019
  17. 13/14 show-branch: drop unused parameter from show_independent()Jeff King, May 9, 2019
  18. 14/14 verify-commit: simplify parameters to run_gpg_verify()Jeff King, May 9, 2019
  19. Derrick StoleeMay 10, 2019
  20. Derrick StoleeMay 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.