[PATCH 08/14] name-rev: drop unused parameters from is_better_name()
- From
Jeff King <peff@peff.net>
- Date
- May 9, 2019, 21:30 UTC
- Message-ID
- <20190509213056.GH15837@sigill.intra.peff.net>
- In-Reply-To
- <20190509212558.GA15438@sigill.intra.peff.net>
When this function was extracted in 0041bf6544 (name-rev: refactor logic to see if a new candidate is a better name, 2017-03-29), it ended up getting more arguments than it needs.
It's possible we may later use these values to evaluate the name, but since it's a static function with a single caller, it will be easy to add them back then.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/name-rev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/builtin/name-rev.c b/builtin/name-rev.c index 05ccf53e00..16df43473a 100644 --- a/builtin/name-rev.c +++ b/builtin/name-rev.c @@ -40,9 +40,7 @@ static void set_commit_rev_name(struct commit *commit, struct rev_name *name) } static int is_better_name(struct rev_name *name, - const char *tip_name, timestamp_t taggerdate, - int generation, int distance, int from_tag) { @@ -103,8 +101,7 @@ static void name_rev(struct commit *commit, name = xmalloc(sizeof(rev_name)); set_commit_rev_name(commit, name); goto copy_data; - } else if (is_better_name(name, tip_name, taggerdate, - generation, distance, from_tag)) { + } else if (is_better_name(name, taggerdate, distance, from_tag)) { copy_data: name->tip_name = tip_name; name->taggerdate = taggerdate;
-- 2.21.0.1382.g4c6032d436