Re: [PATCH v3 1/5] promisor-remote: refactor to get rid of 'struct strvec'

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2025, 15:00 UTC
Message-ID: <xmqqldqqc8kq.fsf@gitster.g>
In-Reply-To: <CAP8UFD25fF6OdYmP54JFyY4Znpij=MR1ifdWk+cjca5Hes739A@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> I don't think it would bring a lot of benefits. Using an strmap or a
> sorted string list might make things faster if there are a lot of
> promisor remotes configured on the clients, but I don't think we are
> at a point where such an optimisation is worth it.

What I was getting at using common collection types instead of rolling your own linked list was not primarily about performance. They are more battle-tested and much easier to readers who are familiar with these existing types.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.