Re: [PATCH v4 2/5] promisor-remote: allow a server to advertise more fields

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 25, 2025, 12:51 UTC
Message-ID: <CAP8UFD3-ayeLMiU+kF_4bF-XnBDT1xuWHzq4eLts9by0WikEhA@mail.gmail.com>
In-Reply-To: <CAOLa=ZSAU4vfNNvcmpVrEavYWss_txVwfutY5ZZLzvVmv5wPdA@mail.gmail.com>

On Thu, Jun 19, 2025 at 2:15 PM Karthik Nayak <karthik.188@gmail.com> wrote:

>
> Christian Couder <christian.couder@gmail.com> writes:

[...]

Show 9 quoted lines

> > +     git -C server remote add otherLop "https://invalid.invalid"  &&
> > +     git -C server config remote.otherLop.token "fooBar" &&
> > +     git -C server config remote.otherLop.stuff "baz" &&
> > +     git -C server config remote.otherLop.partialCloneFilter "blob:limit=10k" &&
> > +     test_when_finished "git -C server remote remove otherLop" &&
> > +     test_config -C server promisor.sendFields "partialCloneFilter, token" &&
>
> What about testing only 'comma' separated and only 'space' separated
> fields, since we support those too.

I think it would only test the following 2 lines from fields_from_config():

string_list_split_in_place(fields_list, fields, ", ", -1); string_list_remove_empty_items(fields_list, 0);

which should be already tested separately in some string_list C tests.

So I don't think it's worth it.

Thanks.