Re: [PATCH 0/1] replay: add --revert option to reverse commit changes

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2025, 18:02 UTC
Message-ID: <xmqqldjurnw2.fsf@gitster.g>
In-Reply-To: <4d75da90-7e85-573a-bb10-0c63a02b076c@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 6 quoted lines

> The patch itself looks fine to me, if a bit too extensive on the side of
> adding tests: Remember, a nimble test suite that catches a bug once is
> better than a long-running test suite that would catch a bug several times
> _iff_ it didn't tax the developer's patience so much that it is
> interrupted and aborted. You probably agree that Git's CI runtimes are
> already counter-productively long.

I am not sure about some of the negations in the above, but it is very good to point out that tests want to cover widely but without overlap. Two tests that try to see the tool works well under identical scenarios can be better done as a single test. We do not need to catch the same bug in multiple tests, as people tend to see test breakages, update the code to fix the first one, and continue, wanting to fix more and different kind of breakages.

Thanks.