Re: [PATCH v3 00/17] Add interpret-trailers builtin
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 27, 2014, 21:05 UTC
- Message-ID
- <xmqqk3dlnnil.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140126165018.24291.47716.chriscool@tuxfamily.org>
Is this from the same Christian?
The series seems to have unusually high rate of style violations compared to the usual submission, like these:
ERROR: open brace '{' following function declarations go on the next line
#78: FILE: trailer.c:44:
+static size_t alnum_len(const char *buf, size_t len) {ERROR: trailing statements should be on next line #79: FILE: trailer.c:45: + while (--len >= 0 && !isalnum(buf[len]));
ERROR: space required before the open parenthesis '('
#70: FILE: trailer.c:90:
+ switch(arg_tok->conf->if_exist) {WARNING: braces {} are not necessary for any arm of this statement
#66: FILE: trailer.c:270:
+ if (!strcasecmp("doNothing", value)) {
[...]
+ } else if (!strcasecmp("add", value)) {
[...]
+ } else
[...]ERROR: that open brace { should be on the previous line
#96: FILE: trailer.c:300:
+ for (previous = NULL, item = first_conf_item;
+ item;
+ previous = item, item = item->next)
+ {Just trying to see if there is an impersonation ;-)