git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 00/17] Add interpret-trailers builtin

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jan 29, 2014, 19:27 UTC
Message-ID
<20140129.202705.1633041266139066645.chriscool@tuxfamily.org>
In-Reply-To
<xmqqk3dlnnil.fsf@gitster.dls.corp.google.com>
From: Junio C Hamano <gitster@pobox.com>
>
> Is this from the same Christian?
Yes, ...
Show 32 quoted lines
> The series seems to have unusually high rate of style violations
> compared to the usual submission, like these:
> 
> ERROR: open brace '{' following function declarations go on the next line
> #78: FILE: trailer.c:44:
> +static size_t alnum_len(const char *buf, size_t len) {
> 
> ERROR: trailing statements should be on next line
> #79: FILE: trailer.c:45:
> +	while (--len >= 0 && !isalnum(buf[len]));
> 
> ERROR: space required before the open parenthesis '('
> #70: FILE: trailer.c:90:
> +	switch(arg_tok->conf->if_exist) {
> 
> WARNING: braces {} are not necessary for any arm of this statement
> #66: FILE: trailer.c:270:
> +	if (!strcasecmp("doNothing", value)) {
> [...]
> +	} else if (!strcasecmp("add", value)) {
> [...]
> +	} else
> [...]
> 
> ERROR: that open brace { should be on the previous line
> #96: FILE: trailer.c:300:
> +	for (previous = NULL, item = first_conf_item;
> +	     item;
> +	     previous = item, item = item->next)
> +	{
> 
> Just trying to see if there is an impersonation ;-)
... I guess the artistic part of my mind is trying to come out somehow.

Thanks, Christian.

Previous: Junio C Hamano
Message 26 of 26 in “Add interpret-trailers builtin”
  1. 00/17 Add interpret-trailers builtinChristian Couder, Jan 26, 2014
  2. 01/17 Add data structures and basic functions for commit trailersChristian Couder, Jan 26, 2014
  3. 02/17 trailer: process trailers from file and argumentsChristian Couder, Jan 26, 2014
  4. 03/17 trailer: read and process config informationChristian Couder, Jan 26, 2014
  5. 04/17 trailer: process command line trailer argumentsChristian Couder, Jan 26, 2014
  6. 05/17 strbuf: add strbuf_isspace()Christian Couder, Jan 26, 2014
  7. 06/17 trailer: parse trailers from input fileChristian Couder, Jan 26, 2014
  8. 07/17 trailer: put all the processing together and printChristian Couder, Jan 26, 2014
  9. 08/17 trailer: add interpret-trailers commandChristian Couder, Jan 26, 2014
  10. 09/17 trailer: add tests for "git interpret-trailers"Christian Couder, Jan 26, 2014
  11. 10/17 trailer: if no input file is passed, read from stdinChristian Couder, Jan 26, 2014
  12. 11/17 trailer: add new_trailer_item() functionChristian Couder, Jan 26, 2014
  13. 12/17 strbuf: add strbuf_replace()Christian Couder, Jan 26, 2014
  14. 13/17 trailer: execute command from 'trailer.<name>.command'Christian Couder, Jan 26, 2014
  15. 14/17 trailer: add tests for trailer commandChristian Couder, Jan 26, 2014
  16. 15/17 trailer: set author and committer env variablesChristian Couder, Jan 26, 2014
  17. 16/17 trailer: add tests for commands using env variablesChristian Couder, Jan 26, 2014
  18. 17/17 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Jan 26, 2014
  19. Eric SunshineJan 27, 2014
  20. Christian CouderJan 27, 2014
  21. Junio C HamanoJan 27, 2014
  22. Christian CouderJan 29, 2014
  23. Junio C HamanoJan 29, 2014
  24. Eric SunshineFeb 2, 2014
  25. Junio C HamanoJan 27, 2014
  26. Christian CouderJan 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.