git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 06/17] trailer: parse trailers from input file

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jan 26, 2014, 16:59 UTC
Message-ID
<20140126170011.24291.61923.chriscool@tuxfamily.org>
In-Reply-To
<20140126165018.24291.47716.chriscool@tuxfamily.org>

This patch reads trailers from an input file, parses them and puts the result into a doubly linked list.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 trailer.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
diff --git a/trailer.c b/trailer.c
index 89377f2..9ea08a7 100644
--- a/trailer.c
+++ b/trailer.c
@@ -440,3 +440,65 @@ static struct trailer_item *process_command_line_args(int argc, const char **arg
 
 	return arg_tok_first;
 }
+
+static struct strbuf **read_input_file(const char *infile)
+{
+	struct strbuf sb = STRBUF_INIT;
+
+	if (strbuf_read_file(&sb, infile, 0) < 0)
+		die_errno(_("could not read input file '%s'"), infile);
+
+	return strbuf_split(&sb, '\n');
+}
+
+/*
+ * Return the the (0 based) index of the first trailer line
+ * or the line count if there are no trailers.
+ */
+static int find_trailer_start(struct strbuf **lines)
+{
+	int count, start, empty = 1;
+
+	/* Get the line count */
+	for (count = 0; lines[count]; count++);
+
+	/*
+	 * Get the start of the trailers by looking starting from the end
+	 * for a line with only spaces before lines with one ':'.
+	 */
+	for (start = count - 1; start >= 0; start--) {
+		if (strbuf_isspace(lines[start])) {
+			if (empty)
+				continue;
+			return start + 1;
+		}
+		if (strchr(lines[start]->buf, ':')) {
+			if (empty)
+				empty = 0;
+			continue;
+		}
+		return count;
+	}
+
+	return empty ? count : start + 1;
+}
+
+static void process_input_file(const char *infile,
+			       struct trailer_item **infile_tok_first,
+			       struct trailer_item **infile_tok_last)
+{
+	struct strbuf **lines = read_input_file(infile);
+	int start = find_trailer_start(lines);
+	int i;
+
+	/* Print non trailer lines as is */
+	for (i = 0; lines[i] && i < start; i++) {
+		printf("%s", lines[i]->buf);
+	}
+
+	/* Parse trailer lines */
+	for (i = start; lines[i]; i++) {
+		struct trailer_item *new = create_trailer_item(lines[i]->buf);
+		add_trailer_item(infile_tok_first, infile_tok_last, new);
+	}
+}
-- 
1.8.5.2.201.gacc5987
Previous: Christian CouderNext: Christian Couder
Message 7 of 26 in “Add interpret-trailers builtin”
  1. 00/17 Add interpret-trailers builtinChristian Couder, Jan 26, 2014
  2. 01/17 Add data structures and basic functions for commit trailersChristian Couder, Jan 26, 2014
  3. 02/17 trailer: process trailers from file and argumentsChristian Couder, Jan 26, 2014
  4. 03/17 trailer: read and process config informationChristian Couder, Jan 26, 2014
  5. 04/17 trailer: process command line trailer argumentsChristian Couder, Jan 26, 2014
  6. 05/17 strbuf: add strbuf_isspace()Christian Couder, Jan 26, 2014
  7. 06/17 trailer: parse trailers from input fileChristian Couder, Jan 26, 2014
  8. 07/17 trailer: put all the processing together and printChristian Couder, Jan 26, 2014
  9. 08/17 trailer: add interpret-trailers commandChristian Couder, Jan 26, 2014
  10. 09/17 trailer: add tests for "git interpret-trailers"Christian Couder, Jan 26, 2014
  11. 10/17 trailer: if no input file is passed, read from stdinChristian Couder, Jan 26, 2014
  12. 11/17 trailer: add new_trailer_item() functionChristian Couder, Jan 26, 2014
  13. 12/17 strbuf: add strbuf_replace()Christian Couder, Jan 26, 2014
  14. 13/17 trailer: execute command from 'trailer.<name>.command'Christian Couder, Jan 26, 2014
  15. 14/17 trailer: add tests for trailer commandChristian Couder, Jan 26, 2014
  16. 15/17 trailer: set author and committer env variablesChristian Couder, Jan 26, 2014
  17. 16/17 trailer: add tests for commands using env variablesChristian Couder, Jan 26, 2014
  18. 17/17 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Jan 26, 2014
  19. Eric SunshineJan 27, 2014
  20. Christian CouderJan 27, 2014
  21. Junio C HamanoJan 27, 2014
  22. Christian CouderJan 29, 2014
  23. Junio C HamanoJan 29, 2014
  24. Eric SunshineFeb 2, 2014
  25. Junio C HamanoJan 27, 2014
  26. Christian CouderJan 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.